Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in kitti.yaml files #45

Closed
DanielRoeder1 opened this issue Jun 8, 2022 · 1 comment
Closed

Error in kitti.yaml files #45

DanielRoeder1 opened this issue Jun 8, 2022 · 1 comment

Comments

@DanielRoeder1
Copy link

A slight error in the config files resulting in the output trajectories not being written correctly.

From #11 it is apparent that the T_SC matrix in the config.yaml files should be set to the identity matrix if there is no conversion between the camera and sensor frame.

The T_SC matrix in the kitti.yaml files is not correctly set resulting in the following matrix:

[1 0 0 0]
[0 1 0 0]
[0 0 0 1]
[0 0 0 1]

As this matrix has no inverse, the resulting trajectory files (KF_GBA.csv) will contain only nan values.

Fix:
#T_SC
Cam0.T00: 1.0
Cam0.T01: 0.0
Cam0.T02: 0.0
Cam0.T03: 0.0
Cam0.T10: 0.0
Cam0.T11: 1.0
Cam0.T12: 0.0
Cam0.T13: 0.0
Cam0.T20: 0.0
Cam0.T21: 0.0
Cam0.T22: 1.0
Cam0.T23: 0.0
Cam0.T30: 0.0
Cam0.T31: 0.0
Cam0.T32: 0.0
Cam0.T33: 1.0

@patriksc
Copy link
Collaborator

patriksc commented Jun 11, 2022

Thanks for the feedback Daniel - good catch, you are of course right here. Fixed by a446047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants