-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore compatibility back to GHC 7.0 #287
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHC 7.0 and 7.2 strictly follows Haskell Report 2010 and require `Show` as a superclass of `Num` https://www.haskell.org/onlinereport/haskell2010/haskellch6.html#x13-1350006.4 http://hackage.haskell.org/package/base-4.3.0.0/docs/Prelude.html#t:Num http://hackage.haskell.org/package/base-4.4.0.0/docs/Prelude.html#t:Num
Fixes compatibility with GHC 7.0 (bundled with `containers-0.4.0.0`) and GHC 7.2 (bundled with `containers-0.4.1.0`) Changelog: https://github.com/haskell/containers/blob/master/containers/changelog.md#0421--feb-2012
Partially reverting 62605ec
These are released now. |
Thanks! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 24, 2021
Version 1.4.1 * Deduplicate command line options when there is more than one TestReporter. Expose the function that does that, uniqueOptionDescriptions. Version 1.4.0.3 * Fix CPP warning/error macro expansion producing 'defined' has undefined behavior Version 1.4.0.2 * Automatically disable the dependency on the clock package when compiled by ghcjs. Version 1.4.0.1 * The only point of this release is to introduce compatibility with GHCs back to 7.0 (see UnkindPartition/tasty#287). Note, however, that these changes are not merged to the master branch, and the future releases will only support the GHC/base versions from the last 5 years, as per our usual policy. To test with even older GHCs, you'll have to use this particular version of tasty (or have the constraint solver pick it for you when testing with older GHCs). The source of this release is in the support-old-ghcs branch of the tasty repository. Version 1.4 * Change the TreeFold data type to give all functions access to OptionSet * Fix a bug where a looping failure message escaped the time out set for the test * Fix a bug where pattern changes inside the TestTree weren't respected Version 1.3.1 * Add an ability for a test provider to print colorful/formatted output Version 1.3 * IsOption has a new method showDefaultValue for customizing how defaultValues are rendered in the --help output. * Drop support for GHCs older than 5 years * Do not install handlers for the signals that dump core * Export the AnsiTricks type/option * In addition to a Parser, optionParser and suiteOptionParser now return a [String] representing warning messages: - A warning is emitted if an IsOption instance defines multiple options in the implementation of optionCLParser. - An warning is emitted if an IsOption instance's optionCLParser implementation assigns a default value (e.g., with Options.Applicative.value), as this interferes with tasty's ability to read environment variable arguments.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 24, 2021
The only point of this release is to introduce compatibility with GHCs back to 7.0 (see UnkindPartition/tasty#287). Note, however, that these changes are not merged to the master branch, and the future releases will only support the GHC/base versions from the last 5 years, as per our usual policy. To test with even older GHCs, you'll have to use this particular version of tasty-hunit (or have the constraint solver pick it for you when testing with older GHCs). The source of this release is in the support-old-ghcs branch of the tasty repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores compatibility of
tasty
,tasty-hunit
andtasty-quickcheck
with old GHCs, back to GHC 7.0.My applications do not require
tasty-smallcheck
, so I left it as is. If desired, it could be made compatible with GHC 7.0 as well, see Bodigrim@003b2a3, but it involves pretty significant rewrite.I also kept Travis config as is, but if you wish to test backward compatibility regularly, I can submit additional jobs. Here is a witness that the libraries actually build on GHC 7.0: https://travis-ci.com/github/Bodigrim/tasty/builds/207660317