fix move_group_node crash during initialization #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change planning plugin to a list of plugins, according to the change introduced in 12/2023 in moveit rolling. - split request_adapters to request_adapters and response_adapters, according to the refactor of planning pipeline introduced in 10/2023 in moveit rolling.
1 task
fmauch
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Thank you @CalaW
I just tested this locally and it indeed fixes things when built from master. Probably also for the released versions. We really do need an integration test for MoveIt! stuff @RobertWilbrandt @VinDp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #903
Moveit2 recently refactored planning pipeline, we need to change the config file correspondingly. See https://github.com/ros-planning/moveit2/blob/1fb4041e690c64b847d2df1e844c8de148796c86/MIGRATION.md
I tested it locally with URSim. Planning and execution works well.