Skip to content

SJTC: Update to latest upstream JTC API #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Apr 30, 2025

This basically changes things to what I currently have in ros-controls/ros2_controllers#1191 hoping that this will finally get to a mergable point.

@urfeex urfeex requested a review from a team April 30, 2025 11:49
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 77 lines in your changes missing coverage. Please review.

Project coverage is 5.06%. Comparing base (1b121b7) to head (1e7d277).
Report is 433 commits behind head on main.

Files with missing lines Patch % Lines
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% 72 Missing ⚠️
...controllers/scaled_joint_trajectory_controller.hpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1351      +/-   ##
========================================
+ Coverage   3.59%   5.06%   +1.47%     
========================================
  Files         13      33      +20     
  Lines        947    3436    +2489     
  Branches     152     424     +272     
========================================
+ Hits          34     174     +140     
- Misses       843    3260    +2417     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.06% <0.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urfeex urfeex force-pushed the update_jtc_api branch from 7833d62 to 4d350c0 Compare May 5, 2025 07:14
@urfeex urfeex force-pushed the update_jtc_api branch from 4d350c0 to 1e7d277 Compare May 6, 2025 14:03
@urfeex urfeex merged commit e9f580f into UniversalRobots:main May 6, 2025
9 of 15 checks passed
@urfeex urfeex deleted the update_jtc_api branch May 6, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants