-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for force_mode, freedrive and tool contact #138
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 77.48% 78.41% +0.92%
==========================================
Files 95 98 +3
Lines 3939 4317 +378
Branches 385 432 +47
==========================================
+ Hits 3052 3385 +333
- Misses 662 686 +24
- Partials 225 246 +21
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @urmahp for implementing this. From a first glance this looks pretty nice, though I haven't found the time to review this line by line, yet. I'd like to test this out on a real robot a bit before merging, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions about behaviors.
This commit includes following changes: * New control mode for freedrive * New control mode for when the tool is in contact * Commands for stopping and starting tool contact * Commands for stopping and starting force mode * Added force_mode_damping and force_mode_gain_scaling to the constructor * Force mode gain scaling is only available for e-series and therefore it is removed from the control script, when the robot is not e-series * Tool contact example * Test for script command interface * Updated test for reverse interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally found the time to have a proper look at this. This seems to be implemented really well, thank you @urmahp! I'll give it a final test on real hardware tomorrow and we should be good to merge!
There was a copy&paste error in the error output. By using the fallback value directly, this is avoided, if the default value may ever change.
I gave this intensive testing today and I think this is working well as expected, so we can merge it. |
This commit includes following changes:
This PR will require some changes to the ROS and ROS2 drivers, in order for them to use the added commands.