Rename variables in Grid Sensor #5217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongruoping
commented
Apr 1, 2021
| int[] ChannelOffsets; | ||
| string m_Name; | ||
| Vector3 m_CellScale; | ||
| Vector3Int m_GridNum; |
There was a problem hiding this comment.
I explored grouping these parameters into struct. The constructer became cleaner but the code becomes much more verbose since these are used a lot everywhere. Also that brings another problem that in the struct some parameters can be changed at runtime while some cannot, and that will make it even more complicated.
So I decided to leave it as is.
surfnerd
reviewed
Apr 1, 2021
| @@ -37,23 +37,23 @@ public Vector3 CellScale | |||
| } | |||
|
|
|||
| [HideInInspector, SerializeField] | |||
| internal Vector3Int m_GridNumSide = new Vector3Int(16, 1, 16); | |||
| internal Vector3Int m_GridNum = new Vector3Int(16, 1, 16); | |||
There was a problem hiding this comment.
Could this be called GridDimensions, or GridSize? GridNum is confusing to me.
There was a problem hiding this comment.
I was thinking this as "number of grids" on each side. I'll change it to GridSize.
surfnerd
approved these changes
Apr 1, 2021
chriselion
approved these changes
Apr 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Renaming variables to better follow naming conventions.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments