Skip to content

Commit 82464ac

Browse files
author
Ruo-Ping Dong
authored
Rename variables in Grid Sensor (#5217)
1 parent e5395a3 commit 82464ac

File tree

6 files changed

+198
-285
lines changed

6 files changed

+198
-285
lines changed

Project/Assets/ML-Agents/Examples/FoodCollector/Prefabs/FoodCollectorArea.prefab

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2308,16 +2308,16 @@ MonoBehaviour:
23082308
m_EditorClassIdentifier:
23092309
m_SensorName: GridSensor
23102310
m_CellScale: {x: 1, y: 0.01, z: 1}
2311-
m_GridNumSide: {x: 40, y: 1, z: 40}
2311+
m_GridSize: {x: 40, y: 1, z: 40}
23122312
m_RotateWithAgent: 1
2313-
m_ChannelDepth: 06000000
2313+
m_ChannelDepths: 06000000
23142314
m_DetectableObjects:
23152315
- food
23162316
- agent
23172317
- wall
23182318
- badFood
23192319
- frozenAgent
2320-
m_ObserveMask:
2320+
m_ColliderMask:
23212321
serializedVersion: 2
23222322
m_Bits: 307
23232323
m_DepthType: 1
@@ -2653,16 +2653,16 @@ MonoBehaviour:
26532653
m_EditorClassIdentifier:
26542654
m_SensorName: GridSensor
26552655
m_CellScale: {x: 1, y: 0.01, z: 1}
2656-
m_GridNumSide: {x: 40, y: 1, z: 40}
2656+
m_GridSize: {x: 40, y: 1, z: 40}
26572657
m_RotateWithAgent: 1
2658-
m_ChannelDepth: 06000000
2658+
m_ChannelDepths: 06000000
26592659
m_DetectableObjects:
26602660
- food
26612661
- agent
26622662
- wall
26632663
- badFood
26642664
- frozenAgent
2665-
m_ObserveMask:
2665+
m_ColliderMask:
26662666
serializedVersion: 2
26672667
m_Bits: 307
26682668
m_DepthType: 1
@@ -3003,16 +3003,16 @@ MonoBehaviour:
30033003
m_EditorClassIdentifier:
30043004
m_SensorName: GridSensor
30053005
m_CellScale: {x: 1, y: 0.01, z: 1}
3006-
m_GridNumSide: {x: 40, y: 1, z: 40}
3006+
m_GridSize: {x: 40, y: 1, z: 40}
30073007
m_RotateWithAgent: 1
3008-
m_ChannelDepth: 06000000
3008+
m_ChannelDepths: 06000000
30093009
m_DetectableObjects:
30103010
- food
30113011
- agent
30123012
- wall
30133013
- badFood
30143014
- frozenAgent
3015-
m_ObserveMask:
3015+
m_ColliderMask:
30163016
serializedVersion: 2
30173017
m_Bits: 307
30183018
m_DepthType: 1
@@ -3622,16 +3622,16 @@ MonoBehaviour:
36223622
m_EditorClassIdentifier:
36233623
m_SensorName: GridSensor
36243624
m_CellScale: {x: 1, y: 0.01, z: 1}
3625-
m_GridNumSide: {x: 40, y: 1, z: 40}
3625+
m_GridSize: {x: 40, y: 1, z: 40}
36263626
m_RotateWithAgent: 1
3627-
m_ChannelDepth: 06000000
3627+
m_ChannelDepths: 06000000
36283628
m_DetectableObjects:
36293629
- food
36303630
- agent
36313631
- wall
36323632
- badFood
36333633
- frozenAgent
3634-
m_ObserveMask:
3634+
m_ColliderMask:
36353635
serializedVersion: 2
36363636
m_Bits: 307
36373637
m_DepthType: 1
@@ -3958,16 +3958,16 @@ MonoBehaviour:
39583958
m_EditorClassIdentifier:
39593959
m_SensorName: GridSensor
39603960
m_CellScale: {x: 1, y: 0.01, z: 1}
3961-
m_GridNumSide: {x: 40, y: 1, z: 40}
3961+
m_GridSize: {x: 40, y: 1, z: 40}
39623962
m_RotateWithAgent: 1
3963-
m_ChannelDepth: 06000000
3963+
m_ChannelDepths: 06000000
39643964
m_DetectableObjects:
39653965
- food
39663966
- agent
39673967
- wall
39683968
- badFood
39693969
- frozenAgent
3970-
m_ObserveMask:
3970+
m_ColliderMask:
39713971
serializedVersion: 2
39723972
m_Bits: 307
39733973
m_DepthType: 1

com.unity.ml-agents.extensions/Editor/GridSensorComponentEditor.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@ public override void OnInspectorGUI()
2626
EditorGUILayout.LabelField("Grid Settings", EditorStyles.boldLabel);
2727
EditorGUILayout.PropertyField(so.FindProperty(nameof(GridSensorComponent.m_CellScale)), true);
2828
// We only supports 2D GridSensor now so display gridNumSide as Vector2
29-
var gridNumSide = so.FindProperty(nameof(GridSensorComponent.m_GridNumSide));
30-
var gridNumSide2d = new Vector2Int(gridNumSide.vector3IntValue.x, gridNumSide.vector3IntValue.z);
31-
var newGridNumSide = EditorGUILayout.Vector2IntField("Grid Num Side", gridNumSide2d);
32-
gridNumSide.vector3IntValue = new Vector3Int(newGridNumSide.x, 1, newGridNumSide.y);
29+
var gridSize = so.FindProperty(nameof(GridSensorComponent.m_GridSize));
30+
var gridSize2d = new Vector2Int(gridSize.vector3IntValue.x, gridSize.vector3IntValue.z);
31+
var newGridSize = EditorGUILayout.Vector2IntField("Grid Size", gridSize2d);
32+
gridSize.vector3IntValue = new Vector3Int(newGridSize.x, 1, newGridSize.y);
3333
EditorGUILayout.PropertyField(so.FindProperty(nameof(GridSensorComponent.m_RootReference)), true);
3434
}
3535
EditorGUI.EndDisabledGroup();
@@ -41,7 +41,7 @@ public override void OnInspectorGUI()
4141
EditorGUILayout.PropertyField(so.FindProperty(nameof(GridSensorComponent.m_DepthType)), true);
4242

4343
// channel depth
44-
var channelDepth = so.FindProperty(nameof(GridSensorComponent.m_ChannelDepth));
44+
var channelDepth = so.FindProperty(nameof(GridSensorComponent.m_ChannelDepths));
4545
var newDepth = EditorGUILayout.IntField("Channel Depth", channelDepth.arraySize);
4646
if (newDepth != channelDepth.arraySize)
4747
{
@@ -75,7 +75,7 @@ public override void OnInspectorGUI()
7575
EditorGUILayout.PropertyField(so.FindProperty(nameof(GridSensorComponent.m_InitialColliderBufferSize)), true);
7676
}
7777
EditorGUI.EndDisabledGroup();
78-
EditorGUILayout.PropertyField(so.FindProperty(nameof(GridSensorComponent.m_ObserveMask)), true);
78+
EditorGUILayout.PropertyField(so.FindProperty(nameof(GridSensorComponent.m_ColliderMask)), true);
7979
EditorGUI.BeginDisabledGroup(!EditorUtilities.CanUpdateModelProperties());
8080
{
8181
EditorGUILayout.LabelField("Sensor Settings", EditorStyles.boldLabel);

0 commit comments

Comments
 (0)