Skip to content

[fix] Doc Low Level Api Agent instead of group #3731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

DemyCode
Copy link

@DemyCode DemyCode commented Apr 3, 2020

Fix in the documentation.

Proposed change(s)

Changing a typo in the documentation.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

vincentpierre added a commit that referenced this pull request Apr 3, 2020
vincentpierre added a commit that referenced this pull request Apr 3, 2020
* Edited the Documentation for the changes to the LLAPI

* Forgot the CHANGELOG

* Fixing a typo raised by #3731

* [skip ci] Update com.unity.ml-agents/CHANGELOG.md

* [skip ci] Update docs/Migrating.md

* [skip ci] Update docs/Python-API.md

* [skip ci] Update docs/Python-API.md
vincentpierre added a commit that referenced this pull request Apr 6, 2020
* [skip ci] WIP : Modify the base_env.py file

* [skip ci] typo

* [skip ci] renamed some methods

* [skip ci] Incorporated changes from our meeting

* [skip ci] everything is broken

* [skip ci] everything is broken

* [skip ci] formatting

* Fixing the gym tests

* Fixing bug, C# has an error that needs fixing

* Fixing the test

* relaxing the threshold of 0.99 to 0.9

* fixing the C# side

* formating

* Fixed the llapi integratio test

* [Increasing steps for testing]

* Fixing the python tests

* Need __contains__ after all

* changing the max_steps in the tests

* addressing comments

* Making env_manager logic clearer as proposed in the comments

* Remove duplicated logic and added back in episode length (#3728)

* removing mentions of multi-agent in gym and changed the docstring in base_env.py

* Edited the Documentation for the changes to the LLAPI (#3733)

* Edited the Documentation for the changes to the LLAPI

* Forgot the CHANGELOG

* Fixing a typo raised by #3731

* [skip ci] Update com.unity.ml-agents/CHANGELOG.md

* [skip ci] Update docs/Migrating.md

* [skip ci] Update docs/Python-API.md

* [skip ci] Update docs/Python-API.md

* Resolving silent merge conflicts

* [skip ci] Update docs/Python-API.md

* [skip ci] Update docs/Python-API.md

* [skip ci] Update gym-unity/README.md

* [skip ci] Update docs/Python-API.md

* Added a sentence asking people to use the llapi instead of gym for multi-agents

Co-authored-by: Ervin T <ervin@unity3d.com>
@vincentpierre
Copy link
Contributor

Hi @DemyCode
We modified the Python API and the documentation associated with it. Your PR was taken into account when changing the docs.
Thank you for your contribution.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants