[refactor] Remove duplicated logic from AgentProcessor#3728
Merged
Conversation
8 tasks
vincentpierre
approved these changes
Apr 3, 2020
Contributor
|
Thanks, I approved it. That's pretty nice. |
vincentpierre
added a commit
that referenced
this pull request
Apr 6, 2020
* [skip ci] WIP : Modify the base_env.py file * [skip ci] typo * [skip ci] renamed some methods * [skip ci] Incorporated changes from our meeting * [skip ci] everything is broken * [skip ci] everything is broken * [skip ci] formatting * Fixing the gym tests * Fixing bug, C# has an error that needs fixing * Fixing the test * relaxing the threshold of 0.99 to 0.9 * fixing the C# side * formating * Fixed the llapi integratio test * [Increasing steps for testing] * Fixing the python tests * Need __contains__ after all * changing the max_steps in the tests * addressing comments * Making env_manager logic clearer as proposed in the comments * Remove duplicated logic and added back in episode length (#3728) * removing mentions of multi-agent in gym and changed the docstring in base_env.py * Edited the Documentation for the changes to the LLAPI (#3733) * Edited the Documentation for the changes to the LLAPI * Forgot the CHANGELOG * Fixing a typo raised by #3731 * [skip ci] Update com.unity.ml-agents/CHANGELOG.md * [skip ci] Update docs/Migrating.md * [skip ci] Update docs/Python-API.md * [skip ci] Update docs/Python-API.md * Resolving silent merge conflicts * [skip ci] Update docs/Python-API.md * [skip ci] Update docs/Python-API.md * [skip ci] Update gym-unity/README.md * [skip ci] Update docs/Python-API.md * Added a sentence asking people to use the llapi instead of gym for multi-agents Co-authored-by: Ervin T <ervin@unity3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Moved common logic into a separate function. Also re-added episode length summary recording.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Adjustment to https://github.com/Unity-Technologies/ml-agents/pull/3681/files
Types of change(s)
Checklist
Other comments