Skip to content

gym - handle uint8_visual for observation space #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2019
Merged

gym - handle uint8_visual for observation space #2783

merged 2 commits into from
Oct 24, 2019

Conversation

chriselion
Copy link
Contributor

  • Fixes a bug introduced in Use a namedtuple for Camera Resolution, not a dict #2656 when accessing the camera resolutions
  • Fixes a bug introduced by the agent/brain refactoring, where the brain parameters aren't always present after environment initialization.
  • Fixes the observation space when using uint8_visual

chriselion
chriselion commented Oct 23, 2019
View reviewed changes
gym-unity/gym_unity/envs/__init__.py Outdated
@@ -51,6 +51,10 @@ def __init__(
self._env = UnityEnvironment(
environment_filename, worker_id, no_graphics=no_graphics
)

# Take a single step so that the brain information will be sent over
self._env.step()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vincentpierre Any other suggestions on how to do this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know of a good way. maybe you could check first if there are no brains at all ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

ervteng
ervteng approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriselion chriselion merged commit 747883d into develop Oct 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the develop-fix-gym-visobs branch October 24, 2019 17:32
@chriselion chriselion mentioned this pull request Nov 6, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ervteng ervteng ervteng approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriselion @ervteng @vincentpierre