fix: client destroy exception #981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
reviewed
Jul 26, 2021
Comment on lines
+420
to
+423
| if (NetworkManager != null && NetworkManager.IsListening && NetworkManager.IsServer == false && IsSpawned) | ||
| { | ||
| throw new NotServerException($"Destroy a spawned {nameof(NetworkObject)} on a non-host client is not valid. Call {nameof(Destroy)} or {nameof(Despawn)} on the server/host instead."); | ||
| } |
There was a problem hiding this comment.
this looks safe to me but I'll defer to Noel for the final call.
NoelStephensUnity
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Good idea...
If you are connected then clients should never do this if the NetworkObject is spawned.
If you are connected but not spawned, then you can continue with the destroy process.
If you are disconnected (and obviously not spawned) then you can continue with the destroy process.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client destroying a spawned network object will now result in a
NotServerException. This is done because this is an invalid operation as only the server can destroy/despawn a spawned network object.