Skip to content

Add in missing defines #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Add in missing defines #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions com.unity.multiplayer.mlapi/Runtime/Metrics/NetworkMetrics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#if MULTIPLAYER_TOOLS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not vetoing this or anything but I do wonder if it would be easier to just compile out the whole file. I don't think an IDE would correctly put a new using into this block if a new one is added. We would probably catch this in code review though


using System.Collections.Generic;
using Unity.Multiplayer.NetStats.Dispatch;
using Unity.Multiplayer.NetStats.Metrics;
Expand All @@ -6,7 +8,6 @@

namespace MLAPI.Metrics
{
#if MULTIPLAYER_TOOLS
public class NetworkMetrics : INetworkMetrics
{
private readonly NetworkManager m_NetworkManager;
Expand Down Expand Up @@ -148,5 +149,6 @@ static MLAPIObserver()
Observer = new NetStatObserver();
}
}
#endif
}

#endif