fix: MLAPI spawned objects now sets NetworkManager override #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -225,6 +225,8 @@ internal NetworkObject CreateLocalNetworkObject(bool softCreate, uint prefabHash | |||
| // Otherwise, instantiate an instance of the NetworkPrefab linked to the prefabHash | |||
| var networkObject = ((position == null && rotation == null) ? UnityEngine.Object.Instantiate(networkPrefabReference) : UnityEngine.Object.Instantiate(networkPrefabReference, position.GetValueOrDefault(Vector3.zero), rotation.GetValueOrDefault(Quaternion.identity))).GetComponent<NetworkObject>(); | |||
|
|
|||
| networkObject.NetworkManagerTestOverride = NetworkManager; | |||
There was a problem hiding this comment.
Probably worth a comment saying something like "by default all network objects are spawned with this singleton, central NM which can be overridden for testing"
There was a problem hiding this comment.
as per my comments in #762, I'm still not 100% onboard with this approach yet.
mattwalsh-unity
approved these changes
Apr 23, 2021
…-network-transform
…oval-spawn-manager-ownership
NoelStephensUnity
approved these changes
Apr 26, 2021
0xFA11
approved these changes
Apr 26, 2021
TwoTenPvP
added a commit
that referenced
this pull request
Apr 29, 2021
* fix: MLAPI spawned objects now sets NetworkManager override (#767)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.