Skip to content

fix: RpcQueueProcessor now uses the correct instance to invoke #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Apr 22, 2021
Merged

fix: RpcQueueProcessor now uses the correct instance to invoke #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
bf2a69f
refactor: InternalMessageHandler is no longer static
TwoTenPvP Apr 6, 2021
b74d51b
Merge branch 'develop' into singleton-removal-message-handler
TwoTenPvP Apr 6, 2021
9cbc9fc
Merge
TwoTenPvP Apr 6, 2021
e9e3f89
Added tests
TwoTenPvP Apr 8, 2021
de31f81
Minor style fix
TwoTenPvP Apr 8, 2021
2802651
Merge branch 'develop' into singleton-removal-message-handler
TwoTenPvP Apr 8, 2021
12c4dbd
renamed test file
TwoTenPvP Apr 9, 2021
708018e
Merge branch 'develop' into singleton-removal-message-handler
TwoTenPvP Apr 9, 2021
12054c5
Added NetworkManager field
TwoTenPvP Apr 12, 2021
f9b27f2
Fix assignment when overriden
TwoTenPvP Apr 12, 2021
18f8fc8
refactor!: CustomMessageManager is no longer static
TwoTenPvP Apr 15, 2021
49c9a1c
refactor!: NetworkSceneManager is no longer static
TwoTenPvP Apr 15, 2021
3ab6a12
add tests
TwoTenPvP Apr 15, 2021
a6c6d43
Fixed missing conversion
TwoTenPvP Apr 15, 2021
4ec2368
Merge branch 'singleton-removal-custom-message-manager' into singleto…
TwoTenPvP Apr 15, 2021
98a3d5b
refactor: InternalMessageSender is no longer static
TwoTenPvP Apr 15, 2021
7d34355
add tests
TwoTenPvP Apr 15, 2021
99fa0d1
fix: RpcQueueProcessor now uses the correct instance to invoke
TwoTenPvP Apr 16, 2021
5622a09
remove unused usings
TwoTenPvP Apr 22, 2021
6cf4a09
Merge branch 'develop' into rpc-queue-processor-invokes-instance
TwoTenPvP Apr 22, 2021
644a793
Merge branch 'develop' into rpc-queue-processor-invokes-instance
TwoTenPvP Apr 22, 2021
77bb82b
Merge branch 'develop' into rpc-queue-processor-invokes-instance
TwoTenPvP Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
using UnityEngine;
using System.Linq;
using MLAPI.Logging;
using UnityEngine.SceneManagement;
using MLAPI.Configuration;
using MLAPI.Internal;
using MLAPI.Profiling;
Expand Down
2 changes: 1 addition & 1 deletion com.unity.multiplayer.mlapi/Runtime/Messaging/RpcQueue/RpcQueueProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public void ProcessReceiveQueue(NetworkUpdateStage currentStage, bool isTesting)

if (!isTesting)
{
NetworkManager.Singleton.InvokeRpc(currentQueueItem);
m_NetworkManager.InvokeRpc(currentQueueItem);
}

ProfilerStatManager.RpcsQueueProc.Record();
Expand Down