refactor!: NetworkSceneManager is no longer static #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Access CustomMessageManager with NetworkManager.Singleton.CustomMessageManager
BREAKING CHANGE: Access NetworkSceneManager with NetworkManager.Singleton.SceneManager
…n-removal-scene-manager
| @@ -304,11 +308,6 @@ private void Init(bool server) | |||
| MessageHandler = new InternalMessageHandler(this); | |||
| } | |||
|
|
|||
| NetworkSceneManager.RegisteredSceneNames.Clear(); | |||
There was a problem hiding this comment.
I assume we no longer need this because, even if we call Init() multiple times (e.g. call StartServer again after stopping) we are creating a new NetworkSceneManager, and the old one will be out of scope and be freed
Still, is there value in, if there already is a NetworkSceneManager, that we call perhaps a cleanup function on it that would do things like the code that was removed? And then ditto for the others here (CustomMessagingManager, BufferManager, etc)
There was a problem hiding this comment.
This way we do it currently fully cleans it up though. (Lists etc are actually thrown out instead of their Count being set to 0 and their underlying array still being present).
mattwalsh-unity
suggested changes
Apr 16, 2021
Base automatically changed from
singleton-removal-custom-message-manager
to
develop
April 16, 2021 08:59
mattwalsh-unity
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Access NetworkSceneManager with NetworkManager.Singleton.SceneManager