ci: Enabling MLAPI UTP Transport package #736
Conversation
Enabling CI for UTP packages
updating min version to 2020.3 for mlapi and utp package.
wackoisgod
requested review from
JesseOlmer,
mattwalsh-unity,
fraserhutch2020 and
cdmazom
com.unity.multiplayer.transport.utp/Tests/Editor/com.unity.multiplayer.mlapi.editortests.asmdef
Outdated
Show resolved
Hide resolved
Fixing naming of asmdef file and fixing yaml files
| @@ -7,7 +7,6 @@ test_editors: | |||
| - 2021.1 | |||
| - 2021.2 | |||
| - 2020.3 | |||
| - 2019.4 | |||
There was a problem hiding this comment.
um, we want to disable 2019 validation?
There was a problem hiding this comment.
Yes, this was called out in the Netcode slack :D that since UTP doesn't support 2019.4 and fails all 2019.4 we would up the min spec to 20.3
| if (item.InternalId == id) | ||
| return item; | ||
| } | ||
|
|
||
| return default; | ||
| } | ||
|
|
||
| public override ulong GetCurrentRtt(ulong clientId) => 0; | ||
|
|
||
| private NetworkPipeline[] networkPipelines = new NetworkPipeline[3]; |
There was a problem hiding this comment.
nice cleanup to not need these anymore
| @@ -2,8 +2,8 @@ | |||
| "name": "com.unity.multiplayer.mlapi", | |||
| "displayName": "MLAPI Networking Library", | |||
| "version": "0.1.0", | |||
| "unity": "2019.4", | |||
There was a problem hiding this comment.
This means the min for MLAPI becomes 2020.3?
| writer.WriteBytes(dataArrayPtr, data.Count); | ||
| } | ||
|
|
||
| SendToClient(writer.AsNativeArray(), peerId, pipelineIndex); |
There was a problem hiding this comment.
I'm missing how pipelineIndex gets set. Else it will always use the NullPipelineState?
There was a problem hiding this comment.
Yea as mentioned in the comment we are re-writing the this, but in order to move the STAR Document forward I need to be able to publish the package and pass validation and I also had to fix compile errors since this package wasn't in CI to begin with.
There was a problem hiding this comment.
ah, ok...I guess if this feature is disabled and we can't ship without it re-enabled it would seem worth a comment here and/or ticket targeted for 1.0.0 so we don't forget
There was a problem hiding this comment.
We have a ticket in the Server Jira to re-write all this code :P
| using UnityEngine.TestTools; | ||
| using NUnit.Framework; | ||
| using Unity.Networking.Transport; | ||
|
|
There was a problem hiding this comment.
Would it be practical to add a test where we standup 2 UTPTransport instances and send to each other?
There was a problem hiding this comment.
Yes, we will do that :P as mentioned before had to add testing to get validation passing.
This enables in CI files the building and packaging of the MLAPI Transport UTP Package. This is needed for the STAR document, it also ensures that we not breaking code in the package.
Also fixes code formatting issues in the MLAPI UTP Package.
Also makes the min version of things 2020.3.0f1
Note This is not the final version of the MLAPI Transport package implementation/testing this is just to get CI working and package validation passing.