Skip to content

ci: streamline PR and nightly CI jobs #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 60 commits into from
Mar 27, 2021

Conversation

seanstolberg-unity
Copy link
Contributor

Updates to build scripts:

  1. Break package tests out into separate build file from the project tests
  2. Create some "run all" wrapper jobs for package and project tests
  3. Update naming on the test jobs a bit
  4. Create a Nightly Develop trigger that will run all tests and run code coverage

flavor: {{ test_platforms.first.flavor}}
commands:
- npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
- {% if platform.name == "centos" %}DISPLAY=:0 {% endif %}upm-ci project test -u {{ test_editors.first }} --type vetting-tests --package-filter {{ package.name }} --platform editmode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have a left-over artifact here of when this was doing multiple package validation... {{ package.name }} likely won't resolve since you no longer define this inside a for loop for each package...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may not understand. This is how it looks like when it it's expanded (using the Yamato yaml linter). Should we be expecting something else? I may just be confused.

validate_com.unity.multiplayer.mlapi_win_2021.1:
  name : Validate Package com.unity.multiplayer.mlapi - 2021.1 on win
  agent:
    type: Unity::VM
    image: package-ci/win10:stable
    flavor: b1.large
  commands:
    - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
    - upm-ci project test -u 2021.1 --type vetting-tests --package-filter com.unity.multiplayer.mlapi --platform editmode
  artifacts:
    logs:
      paths:
        - "upm-ci~/test-results/**/*"
  dependencies:
    - .yamato/project-pack.yml#pack_testproject
validate_com.unity.multiplayer.transport.utp_win_2021.1:
  name : Validate Package com.unity.multiplayer.transport.utp - 2021.1 on win
  agent:
    type: Unity::VM
    image: package-ci/win10:stable
    flavor: b1.large
  commands:
    - npm install upm-ci-utils@stable -g --registry https://artifactory.prd.cds.internal.unity3d.com/artifactory/api/npm/upm-npm
    - upm-ci project test -u 2021.1 --type vetting-tests --package-filter com.unity.multiplayer.transport.utp --platform editmode
  artifacts:
    logs:
      paths:
        - "upm-ci~/test-results/**/*"
  dependencies:
    - .yamato/project-pack.yml#pack_testproject

Copy link
Contributor

@JesseOlmer JesseOlmer Mar 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you added the package for loop on line 8 it fixed this problem. This comment was before that was added. Looks perfect now!

@JesseOlmer JesseOlmer changed the title Experimental/update test jobs ci: streamline PR and nightly CI jobs Mar 26, 2021
@JesseOlmer
Copy link
Contributor

Overall looks pretty good - I'm excited for the optimizations. Our repo is in a bit of an odd spot where we have multiple packages, but we only run tests for 1 of them right now since that's the only one we ship. Nevertheless, we want to be setup to easily enable the other one as soon as we need it.

Copy link
Contributor

@JesseOlmer JesseOlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@JesseOlmer JesseOlmer disabled auto-merge March 27, 2021 16:25
@JesseOlmer JesseOlmer merged commit e9c826f into develop Mar 27, 2021
@JesseOlmer JesseOlmer deleted the experimental/update-test-jobs branch March 27, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants