fix: backport TickSystemTests.VerifyTickSystem() test #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwalsh-unity
approved these changes
Mar 23, 2021
| { | ||
| private NetworkTickSystem m_TickSystem = null; | ||
| private float m_TestDuration = 5.0f; | ||
| private float m_TestDuration = 3.0f; |
There was a problem hiding this comment.
Nit, but I would probably make the test duration be expressed as some multiple of the tick interval (e.g. 100 * m_TickInterval), and by the same token make the sleep interval expressed as some fraction of the tick interval vs. having purely magic number constants
There was a problem hiding this comment.
agreed — @jeffreyrainy for more visibility on your feedback :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backporting b2a54ec fix that went into
master(release) back todeveloptoo.