Skip to content

refactor: move RpcBatcher under Messaging namespace and directory #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2021
Merged

refactor: move RpcBatcher under Messaging namespace and directory #474

merged 1 commit into from
Feb 9, 2021

Conversation

0xFA11
Copy link
Contributor

@0xFA11 0xFA11 commented Feb 9, 2021

No description provided.

NoelStephensUnity
NoelStephensUnity approved these changes Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and clean.
Move files...adjust namespace and namespace references...done!

jeffreyrainy
jeffreyrainy approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@jeffreyrainy jeffreyrainy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job. Well contained PR

@0xFA11 0xFA11 merged commit 27263d3 into develop Feb 9, 2021
@0xFA11 0xFA11 deleted the refactor/relocate-rpc-batcher branch March 5, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyrainy jeffreyrainy jeffreyrainy approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xFA11 @jeffreyrainy @NoelStephensUnity