Skip to content

fix: NetworkTransform cannot set non-synchronized axis on non-authority instances #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 30, 2025

Issue verified when investigating ForumSupport-939437.

This PR resolves the issue in v2.x where you cannot update non-synchronized axis values on non-authority instances without having them be reset by the next frame.

MTTB-1334

Changelog

  • Fixed: Issue where non-authority NetworkTransform instances would not allow non-synchronized axis values to be updated locally.

Testing and Documentation

  • Includes the NetworkTransformNonAuthorityTests integration test.
  • No documentation changes or additions were necessary.

Backport

This fix is specific to NGO v2.x.

Allow non-authority instances to adjust non-synchronized axis on NetworkTransform.
work in progress.
potential fix for NetworkTransform non-authority's ability to modify portions of the transform not being synchronized.
Adding the NetworkTransformNonAuthorityTests to validate the fixes in this PR.
removing whitespace
Fixing imports ordering
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 31, 2025 13:40
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 31, 2025 13:40
Adding change log entry
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 31, 2025 16:18
NoelStephensUnity and others added 3 commits May 31, 2025 11:55
Switched to a euler comparison to avoid floating point false negative results.
removing unused parameter.
Copy link
Collaborator

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for getting the test working!

@NoelStephensUnity NoelStephensUnity merged commit 017131d into develop-2.0.0 Jun 2, 2025
42 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networktransform-set-non-synchronized-axis-nonauthority branch June 2, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants