feat: Add support for connecting via a hostname instead of IP #3441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pported versions of unity and unity transport.
ShadauxCat
requested review from
NoelStephensUnity,
EmandM and
a team
as code owners
com.unity.netcode.gameobjects/Tests/Editor/Transports/UnityTransportTests.cs
Outdated
Show resolved
Hide resolved
Adding FQDN validation and updating log errors provided to users. Adding back the invalid address tests to handle newer and older versions of UTP.
Forgot to update for one of the newer error messages when using an invalid address.
Fixing an issue with `ClientDisconnectMultipleClients` beginning to disconnect clients before they were connected. Added `UnityTransportTestHelpers.WaitForMultipleNetworkEvents` helper method to wait for a specific number of events of a specified type. Added a `UnityTransportTestHelpers.VerboseDebug` helper method.
NoelStephensUnity
approved these changes
May 8, 2025
NoelStephensUnity
added a commit
that referenced
this pull request
May 8, 2025
EmandM
approved these changes
May 13, 2025
com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
Outdated
Show resolved
Hide resolved
NoelStephensUnity
added a commit
that referenced
this pull request
May 16, 2025
] (#3440) Add support for connecting via a hostname instead of IP when using supported versions of unity and unity transport. ## Changelog - Added: When using UnityTransport >=2.4 and Unity >= 6000.1.0a1, `SetConnectionData` will accept a fully qualified hostname instead of an IP as a connect address on the client side. ## Testing and Documentation - No tests have been added. (Manual tests were performed. The CI environment doesn't have "localhost" consistently defined to be able to run automated tests.) - Includes edits to existing public API documentation. ## Backport Backport of #3441 --------- Co-authored-by: NoelStephensUnity <noel.stephens@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for connecting via a hostname instead of IP when using supported versions of unity and unity transport.
Changelog
SetConnectionDatawill accept a fully qualified hostname instead of an IP as a connect address on the client side.Testing and Documentation
Backport
Backport: #3440