fix: tools metrics dispatcher related memory leak [Backport] #3428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playModeStateChanged never gets unsubscribed
NoelStephensUnity
changed the title
EmandM
approved these changes
Apr 25, 2025
NoelStephensUnity
added a commit
that referenced
this pull request
Apr 25, 2025
playModeStateChanged never gets unsubscribed in NetworkManager and keeps Multiplayer Tools MetricsDispatcher instances alive through NetworkMetrics when domain reload is disabled. Jira ticket: [MTT-11638](https://jira.unity3d.com/browse/MTT-11638) ## Changelog - Fixed: Memory leaks when domain reload is disabled. ## Testing and Documentation - No tests have been added. ## Backport Requires backport to v1.x. (#3428) --------- Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
NoelStephensUnity
deleted the
fix/tools-metrics-dispatcher-memory-leak-backport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playModeStateChanged never gets unsubscribed in NetworkManager and keeps Multiplayer Tools MetricsDispatcher instances alive through NetworkMetrics when domain reload is disabled.
Jira ticket: MTT-11638
Changelog
Testing and Documentation
Backport
This is a backport of #3427