fix: fastbufferreader does not honor arraysegment configuration #3320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
added
the
port:2.x-needed
NoelStephensUnity
added
the
port:2.x-completed
…segment-configuration
EmandM
approved these changes
Feb 25, 2025
EmandM
deleted the
fix/fastbufferreader-does-not-honor-arraysegment-configuration
branch
EmandM
pushed a commit
that referenced
this pull request
Feb 25, 2025
…ort) (#3321) Up port of #3320 This PR resolves the issue where `FastBufferReader` did not provide constructors that would automatically use an `ArraySegment`'s configuration (Count and Offset) to define the `FastBufferReader`. [MTTB-34](https://jira.unity3d.com/browse/MTTB-34) fix: #2885 ## Changelog - Added `FastBufferReader(ArraySegment<byte> buffer, Allocator copyAllocator)` constructor that uses the `ArraySegment.Offset` as the `FastBufferReader` offset and the `ArraySegment.Count` as the `FastBufferReader` length. - Added `FastBufferReader(ArraySegment<byte> buffer, Allocator copyAllocator, int length = -1)` constructor that uses the `ArraySegment.Offset` as the `FastBufferReader` offset. ## Testing and Documentation - Includes unit test. - Includes public API documentation. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where
FastBufferReaderdid not provide constructors that would automatically use anArraySegment's configuration (Count and Offset) to define theFastBufferReader.MTTB-34
fix: #2885
up-port: #3321
Changelog
FastBufferReader(ArraySegment<byte> buffer, Allocator copyAllocator)constructor that uses theArraySegment.Offsetas theFastBufferReaderoffset and theArraySegment.Countas theFastBufferReaderlength.FastBufferReader(ArraySegment<byte> buffer, Allocator copyAllocator, int length = -1)constructor that uses theArraySegment.Offsetas theFastBufferReaderoffset.Testing and Documentation