fix: NetworkAnimator not synchronizing changes to layer weights #2399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding small manual test adjustment to verify the change in a layer weight is synchronized.
…nges-in-layer-weights
ShadauxCat
approved these changes
Feb 1, 2023
| private void LateUpdate() | ||
| { | ||
|
|
||
| if (!IsSpawned || !IsOwner) | ||
| { | ||
| if (!IsOwner && IsSpawned) | ||
| { | ||
| if (Input.GetKeyDown(KeyCode.Alpha4)) |
There was a problem hiding this comment.
This looks like debug code maybe?
There was a problem hiding this comment.
It is part of the manual test that just allows you to verify that when changes are applied to a layer's weight that it was updated on other non-authoritative/owner instances.
| @@ -229,6 +243,10 @@ private void LateUpdate() | |||
| BeginAttack(2); | |||
| } | |||
|
|
|||
| if (Input.GetKeyDown(KeyCode.Alpha3)) | |||
There was a problem hiding this comment.
It is part of the manual test that just allows you to verify that when changes are applied to a layer's weight that it was updated on other non-authoritative/owner instances.
NoelStephensUnity
deleted the
fix/networkanimator-not-synchronizing-changes-in-layer-weights
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where layer weights were not being updated unless a state transition was occurring.
MTT-5389
Changelog
Testing and Documentation