Skip to content

fix: fix UnityTransport_RestartSucceedsAfterFailure test #2347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fluong6
Copy link
Collaborator

@fluong6 fluong6 commented Dec 13, 2022

Fixing a UnityTransport_RestartSucceedsAfterFailure test that was failing when you install NGO package with UTP 2.0.0.

Changelog

  • Fixed: Fixed a UTP test that was failing when you install Unity Transport package 2.0.0 or newer.

Testing and Documentation

Ran the test locally and automated CI run

@fluong6 fluong6 changed the title Fix UnityTransport_RestartSucceedsAfterFailure test fix: fix UnityTransport_RestartSucceedsAfterFailure test Dec 13, 2022
@fluong6 fluong6 marked this pull request as ready for review December 14, 2022 18:30
@fluong6 fluong6 requested review from a team as code owners December 14, 2022 18:30
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and LGTM!

@fluong6 fluong6 enabled auto-merge (squash) December 15, 2022 15:05
@fluong6 fluong6 merged commit f59a68c into develop Dec 15, 2022
@fluong6 fluong6 deleted the fix/fix_utp_unitytransport_restartsucceedssfterfailure_test branch December 15, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants