fix: resetting the NetworkVariable dirty status at end of frame, … #2344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if a given NetworkVariable is not sent to any client
…rklist-hide-remove
…workObject's NetworkShow
…rklist-hide-remove
…PC targets, rather, prevent NetworkVariable deltas from going to objects that are just about to be shown
| @@ -64,6 +64,16 @@ public void Serialize(FastBufferWriter writer, int targetVersion) | |||
| shouldWrite = false; | |||
| } | |||
|
|
|||
| // The object containing the behaviour we're about to process is about to be shown to this client | |||
NoelStephensUnity
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… even if a given NetworkVariable is not sent to any client
Also queueing NetworkShow to be done at end-of-frame, to address modified-after-shown objects.
Also changing NetworkHide so that hiding objects that would be shown at end of frame does nothing, but emit a warning.
MTT-5121
#2306
Changelog:
NetworkShow()ofNetworkObjects are delayed until the end of the frame to ensure consistency of delta-driven variables likeNetworkList.NetworkObjectare reset at end-of-frame and not at serialization time.NetworkHide()of an object that was justNetworkShow()n produces a warning, as remote clients will not get a spawn/despawn pair.