fix: Don't allocate extraneous memory in FastBufferReader #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
reviewed
Oct 19, 2022
| @@ -65,7 +65,7 @@ internal unsafe void CommitBitwiseReads(int amount) | |||
| ReaderHandle* readerHandle = null; | |||
| if (copyAllocator == Allocator.None) | |||
| { | |||
| readerHandle = (ReaderHandle*)UnsafeUtility.Malloc(sizeof(ReaderHandle) + length, UnsafeUtility.AlignOf<byte>(), internalAllocator); | |||
ShadauxCat
approved these changes
Oct 19, 2022
0xFA11
approved these changes
Oct 19, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…nologies#2265) * fix: Don't allocate extraneous memory in FastBufferReader * Add PR number to CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a
FastBufferReaderwithcopyAllocatorset toAllocator.Nonemeans not to allocate a copy of the buffer, and to instead directly use the one provided by the user. But in that situation the code would still allocate memory for the entire buffer. That memory would go unused.Props to user Frolo on Discord for finding this issue.
Changelog
FastBufferReaderwithAllocator.Nonewill not result in extra memory being allocated for the buffer (since it's owned externally in that scenario).Testing and Documentation