refactor: NetworkTransform.SetState shouldGhostsInterpolate parameter [MTT-4462] #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTT-4462 Renaming shouldGhostsInterpolate to isNotTeleporting for better clarity of what that parameter does. While renaming it to isTeleporting would make more sense, that could potentially become a breaking change, and so the next best parameter name would be "isNotTeleporting" which would not break users that use this parameter currently.
ShadauxCat
reviewed
Sep 30, 2022
jeffreyrainy
approved these changes
Dec 2, 2022
…-shouldghostsinterpolate-parameter-mtt-4462
…ostsinterpolate-parameter-mtt-4462
NoelStephensUnity
deleted the
refactor/networktransform-setstate-rename-shouldghostsinterpolate-parameter-mtt-4462
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming
shouldGhostsInterpolatetoteleportDisabledfor better clarity of what that parameter does.MTT-4462
#2120
Changelog
shouldGhostsInterpolatetoteleportDisabledfor better clarity of what that parameter does.Testing and Documentation