Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: test project physics sample #2227

Merged
merged 4 commits into from
Oct 1, 2022
Merged

fix: test project physics sample #2227

merged 4 commits into from
Oct 1, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Sep 30, 2022 •
edited
Loading

Removed the no longer needed NetworkTransform from the PhysicsPlayer.
MTT-4083
#1998

Changelog

  • Fixed: test project PhysicsPlayer prefab no longer needed the NetworkTransform component since PlayerMovement derives from NetworkTransform.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
aee4e77 
Removed the extra NetworkTransform no longer needed form the PhyscisPlayer prefab since the PlayerMovement class derives from NetworkTransform.
@NoelStephensUnity
update
819f38f 
moving the physics sample higher in the list and the sample scene to the bottom.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 30, 2022 02:13
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 30, 2022 02:13
@NoelStephensUnity NoelStephensUnity merged commit b92c6b8 into develop Oct 1, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/test-project-physics-sample branch October 1, 2022 02:30
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
@NoelStephensUnity @jakobbbb
fix: test project physics sample (Unity-Technologies#2227)
1f4ae8d 
* fix
Removed the extra NetworkTransform no longer needed form the PhyscisPlayer prefab since the PlayerMovement class derives from NetworkTransform.

* update
moving the physics sample higher in the list and the sample scene to the bottom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @ShadauxCat