fix: Set state private RPC handlers were not honoring local vs world space assignment of position and rotation #2203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreyrainy
approved these changes
Sep 14, 2022
NoelStephensUnity
deleted the
fix/set-state-networktransform-local-space-is-not-honored
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…space assignment of position and rotation (Unity-Technologies#2203) * fix SetStateClientRpc and SetStateServerRpc were not updated to use SetStateInternal which honors local vs world space transform setting.s * update changelog * test Modified existing tests to include testing SetState which validates the changes made to NetworkTransform.SetState and associated private methods. * update adding the PR number to the changelog entry. * test removing conditional check that was not needed. * update adding further clarity as to where the two rpc methods were located.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed the SetStateServerRpc and SetStateClientRpc were not honoring local vs world position and rotation. This just replaces that legacy code with the SetStateInternal method that does honor local vs world space.
Changelog
SetStateServerRpcandSetStateClientRpcwere not honoring local vs world space settings when applying the position and rotation.Testing and Documentation