feat: Non-deterministic debug simulator in UnityTransport [MTT-4592] #2196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlebedenco
approved these changes
Sep 12, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…nity-Technologies#2196) * feat: Non-deterministic debug simulator in UnityTransport [MTT-4592] * Add PR number to CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike what the code seemed to imply, setting the random seed to 0 in the simulator pipeline stage parameters would not result in its value being determined non-deterministically. It would just pick a hardcoded constant instead.
This PR makes the default seed value be
Stopwatch.GetMilliseconds, while preserving the ability to hardcode a constant for testing purposes. Having a non-deterministic simulator is preferable to a deterministic one, since it better represents the behavior of real networks.Changelog
UnityTransportis now non-deterministic. Its random number generator used to be seeded with a constant value, leading to the same pattern of packet drops, delays, and jitter in every run.Testing and Documentation