fix: Adds a null check for NetworkObjectReference => GameObject conversion [NCCBUG-172] #2158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion [NCCBUG-172]
JesseOlmer
reviewed
Aug 29, 2022
| @@ -139,7 +139,7 @@ public override int GetHashCode() | |||
| /// </summary> | |||
| /// <param name="networkObjectRef">The <see cref="NetworkObjectReference"/> to convert from.</param> | |||
| /// <returns>This returns the <see cref="GameObject"/> that the <see cref="NetworkObject"/> is attached to and is referenced by the <see cref="NetworkObjectReference"/> passed in as a parameter</returns> | |||
| public static implicit operator GameObject(NetworkObjectReference networkObjectRef) => Resolve(networkObjectRef).gameObject; | |||
| public static implicit operator GameObject(NetworkObjectReference networkObjectRef) => Resolve(networkObjectRef)?.gameObject; | |||
There was a problem hiding this comment.
Don't use null-conditional operator on MonoBehaviour's - it's not supported. You have to do the full if (ref != null) and the engine marshalls to native to verify the object hasn't been destroyed.
There was a problem hiding this comment.
Changed. Thanks for pointing that out.
JesseOlmer
reviewed
Aug 29, 2022
com.unity.netcode.gameobjects/Tests/Runtime/Serialization/NetworkObjectReferenceTests.cs
Outdated
Show resolved
Hide resolved
JesseOlmer
reviewed
Aug 29, 2022
com.unity.netcode.gameobjects/Tests/Runtime/Serialization/NetworkObjectReferenceTests.cs
Outdated
Show resolved
Hide resolved
JesseOlmer
suggested changes
Aug 29, 2022
…orkObjectReferenceTests.cs Co-authored-by: Jesse Olmer <jesseo@unity3d.com>
…_GameObject_conversion
JesseOlmer
approved these changes
Aug 29, 2022
…_GameObject_conversion
ShadauxCat
deleted the
fix/null_check_for_NetworkObjectReference_GameObject_conversion
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…rsion [NCCBUG-172] (Unity-Technologies#2158) * fix: Adds a null check for NetworkObjectReference => GameObject conversion [NCCBUG-172] * Changelog * style * Update com.unity.netcode.gameobjects/Tests/Runtime/Serialization/NetworkObjectReferenceTests.cs Co-authored-by: Jesse Olmer <jesseo@unity3d.com> * Review feedback. Co-authored-by: Jesse Olmer <jesseo@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Testing and Documentation