fix: Client RPCs always reporting all RPCs as going to all clients, even when limited by ClientRpcParams [MTT-4468] #2144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven when limited by ClientRpcParams
ian-m-unity
approved these changes
Aug 24, 2022
DenninDalke
approved these changes
Aug 24, 2022
| rpcMethodName, | ||
| __getTypeName(), | ||
| rpcWriteSize); | ||
| } |
There was a problem hiding this comment.
If the clientRpcParams.Send.TargetClientIdsNativeArray didn't cause Boxing allocation I would suggest using something like:
IEnumerable<ulong> enumerable;
if (clientRpcParams.Send.TargetClientIds != null)
{
enumerable = clientRpcParams.Send.TargetClientIds;
}
else if (clientRpcParams.Send.TargetClientIdsNativeArray != null)
{
enumerable = clientRpcParams.Send.TargetClientIdsNativeArray;
}
else
{
enumerable = NetworkObject.Observers;
}
foreach (var networkObject in enumerable)
{
NetworkManager.NetworkMetrics.TrackRpcSent(
networkObject,
NetworkObject,
methodName,
__getTypeName(),
rpcWriteSize);
}
But in this case, it seems there's no other way to achieve the most efficient code without sacrificing a bit of readability.
So I believe your code is the best choice here.
There was a problem hiding this comment.
Yeah, that was my thought, too.
ShadauxCat
deleted the
fix/profiler_showing_rpcs_as_always_going_to_all_clients
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…ven when limited by ClientRpcParams [MTT-4468] (Unity-Technologies#2144) * fix: Client RPCs always reporting all RPCs as going to all clients, even when limited by ClientRpcParams * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Testing and Documentation