fix: NCCBUG-175: BitReader/BitWriter Reading/writing more than 8 bits was producing the wrong result #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was producing the wrong result
com.unity.netcode.gameobjects/Runtime/Serialization/BitWriter.cs
Outdated
Show resolved
Hide resolved
jeffreyrainy
approved these changes
Aug 17, 2022
NoelStephensUnity
deleted the
fix/reading_more_than_8_bytes_returns_wrong_result
branch
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
… was producing the wrong result (Unity-Technologies#2130) * fix: NCCBUG-175: BitReader/BitWriter Reading/writing more than 8 bits was producing the wrong result * Standards + changelog Co-authored-by: Noel Stephens <noel.stephens@unity3d.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation of where to read/write was incorrect. It was taking the parent reader/writer's position into account twice and not counting its own bit-based position.
NCCBUG-175
Changelog
Testing and Documentation