test: Allow for the detection of whether to run Multiprocess tests with local clients or remote clients. #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zain-mecklai
changed the title
zain-mecklai
requested review from
SamuelBellomo,
NoelStephensUnity and
ashwinimurt
testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| else | ||
| else if (m_LaunchRemotely) |
There was a problem hiding this comment.
why else if? Why not just else?
There was a problem hiding this comment.
I usually prefer to be explicit.
There was a problem hiding this comment.
I mean, it's an if on a single bool, that's pretty explicit already
There was a problem hiding this comment.
that's fair, I'll change it.
testproject/Assets/Tests/Runtime/MultiprocessRuntime/BaseMultiprocessTests.cs
Show resolved
Hide resolved
SamuelBellomo
approved these changes
Jul 6, 2022
|
Couple of suggestions for current and future PRs:
|
ashwinimurt
approved these changes
Jul 7, 2022
0xFA11
approved these changes
Jul 7, 2022
respond to PR feedback
zain-mecklai
changed the title
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…nity-Technologies#2054) * Set up for launching remotely * Set up for launching remotely * Report on WorkerCount and LaunchRemotely state * Store the Process as it will complete later * add a little more logging * Simplified name * Update GetWorkerCount to no longer set internal state * Update BaseMultiprocessTests.cs respond to PR feedback Co-authored-by: ashwini <36935028+ashwinimurt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dependency on the environment variable
MP_PLATFORM_LIST. Based on the existence of this variable the Multiprocess tests will switch between running clients locally and running them on remote nodes.Add parsing code for using the value of the variable to determine which types of hosts to run the clients on.
No Jira associated with this whole project.
No RFC associated with this whole project
Changelog
No changes for the testlog
Testing and Documentation
N/A for deprecated API