chore: allowing multiple Connection Approval handlers. [MTT-3496] #1964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion after they all got a chance to decide
jeffreyrainy
commented
May 13, 2022
| @@ -165,14 +165,17 @@ private void ConnectionApprovalCallback(byte[] dataToken, ulong clientId, Networ | |||
|
|
|||
| if (m_GlobalObjectIdHashOverride != 0 && m_PlayerPrefabOverride && m_PlayerPrefabOverride.isOn) | |||
| { | |||
| aprovalCallback.Invoke(true, m_GlobalObjectIdHashOverride, isTokenValid, null, null); | |||
| decision.Approved = isTokenValid; | |||
There was a problem hiding this comment.
Those three lines should be the first focus. The API changed in this way: instead of asking the client code to call a callback, they fill a class with their decision. All the approval handler get to run before the decision is used. Then, the decision is used just once.
|
Superseded by #1972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: allowing multiple Connection Approval handlers. Using the decision after they all got a chance to decide
[MTT-3496]
Changelog
public delegate void ConnectionApprovalDelegate(byte[] payload, ulong clientId, ConnectionApprovalDecision decision);now receives aConnectionApprovalDecisionclass that must be filled, instead of calling a second callback. This allows having multiple Connection Approval handlers. (Exception when there are multiple connectional approval callbacks #1941)