fix: NetworkRigidbody authority and ownership detection #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would really like to see some tests on this so we don't have regressions of this behavior later. |
ShadauxCat
approved these changes
Apr 20, 2022
Realized we could further simplify NetworkRigidbody and added additional testing against owners not being Kinematic and non-owners being kinematic. Also had to have the NetworkManager relative test prefab instances ignore each others' colliders so they wouldn't skew the position testing.
0xFA11
approved these changes
Apr 20, 2022
0xFA11
reviewed
Apr 20, 2022
com.unity.netcode.gameobjects/Tests/Runtime/NetworkTransform/NetworkTransformOwnershipTests.cs
Show resolved
Hide resolved
0xFA11
reviewed
Apr 20, 2022
com.unity.netcode.gameobjects/Tests/Runtime/com.unity.netcode.runtimetests.asmdef
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Apr 20, 2022
com.unity.netcode.gameobjects/Tests/Runtime/com.unity.netcode.runtimetests.asmdef
Outdated
Show resolved
Hide resolved
…runtimetests.asmdef Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
NoelStephensUnity
deleted the
fix/mtt-3374-networkrigidbody-ownership-change-detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refactor of NetworkRigidbody and NetworkTranaform to elminate constant FixedUpdate polling in NetworkRigidBody to detect changes in ownership.
This also fixes an issue where both authoritative and non-authoritative Rigidbodies were not kinematic until spawned, now all instances are set to kinematic until authority is determined and applied (this happens during OnNetworkSpawn and OnGainedOwnership/OnLostOwnership).
MTT-3374
Testing and Documentation