Skip to content

fix: ValidatesSceneBeforeLoading halts client synchronization #1883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 20, 2022
Merged

fix: ValidatesSceneBeforeLoading halts client synchronization #1883

merged 13 commits into from
Apr 20, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 19, 2022 •
edited
Loading

This PR fixes the issue where if a client attempts to reconnect without unloading the scenes and uses ValidateSceneBeforeLoading to bypass loading the scenes that are already loaded, then it will throw an exception and the client cannot continue synchronizing.

MTT-3285

Changelog

  • Fixed: issue during client synchronization if 'ValidateSceneBeforeLoading' returned false it would halt the client synchronization process resulting in a client that was approved but not synchronized or fully connected with the server.

Testing and Documentation

  • Includes integration test.

@NoelStephensUnity
fix MTT-3285
45ed053 
MTT-3285
This fixes the issue with ValidateSceneBeforeLoading not continuing to synchronize if one scene is skipped over.
@NoelStephensUnity
update
6dac842 
adding some debug information (LogLevel.Developer) so users can track when a client declines to load a scene
@NoelStephensUnity
fix
7150a33 
When a scene is not validated on the client side it should invoke HandleClientSceneEvent not ClientLoadedSynchronization
@NoelStephensUnity
test
8ef40a5 
MTT-3285
Integration test
@NoelStephensUnity
style
e550e78
@NoelStephensUnity
Update CHANGELOG.md
fd81302
@NoelStephensUnity
Update CHANGELOG.md
a28e208
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review April 19, 2022 00:44
NoelStephensUnity and others added 2 commits April 18, 2022 19:45
@NoelStephensUnity
style
226e6f1 
removing space in assert message
@NoelStephensUnity
test fix
f78722c 
unload the loaded scenes.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Apr 19, 2022
Closed
@NoelStephensUnity NoelStephensUnity merged commit d220adf into develop Apr 20, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/mtt-3285-validatescenebeforeloading-ending-client-synchronization branch April 20, 2022 16:38
@NoelStephensUnity NoelStephensUnity mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

@0xFA11 0xFA11 Awaiting requested review from 0xFA11

@mattwalsh-unity mattwalsh-unity Awaiting requested review from mattwalsh-unity

@TwoTenPvP TwoTenPvP Awaiting requested review from TwoTenPvP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @ShadauxCat