feat: FastBufferReader/Writer IsInitialized property #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
reviewed
Apr 4, 2022
| @@ -207,7 +213,7 @@ internal unsafe void Grow(int additionalSizeRequired) | |||
| /// When you know you will be writing multiple fields back-to-back and you know the total size, | |||
| /// you can call TryBeginWrite() once on the total size, and then follow it with calls to | |||
| /// WriteValue() instead of WriteValueSafe() for faster serialization. | |||
| /// | |||
| /// | |||
There was a problem hiding this comment.
This change is unacceptable to me. The whitespace at the end of this comment line was critical to the blahdy blah blah blah...
(Thanks for cleaning this up.)
There was a problem hiding this comment.
Haha I don't think that was me but just Rider auto formatting 😆
ShadauxCat
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an IsInitialized property to FastBufferWriter/Reader. This property can be used to check whether they are intialized instead of using
reader.Equals(default)which incurs boxing to Object.Changelog
Testing and Documentation