fix: improve networking warning messages [MTT-1293] #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
reviewed
Mar 31, 2022
0xFA11
reviewed
Mar 31, 2022
0xFA11
reviewed
Mar 31, 2022
0xFA11
approved these changes
Mar 31, 2022
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
Co-authored-by: Fatih Mar <mfatihmar@gmail.com>
jeffreyrainy
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we deal with the "children with no parent" warning. In the old code, we sent an error whenever a child had no parent. This warning, at least in the current design, is not something worth warning users about, because it (if things are working properly) should always resolve, because we always update clients with every newly-spawned object in a single tick.
What is worth warning about is if we get to the end of a tick and still have not resolved the orphans. If this happens, and if the orphans have local transformations you would see popping as they go from an incorrect starting, non-rooted location to the correct location. This PR now warns if this situation happens.
In future, when it is normal behavior to have partial object spawns being synced this warning will need to be changed, but also our scheme for resolving children will need to change too (else there will be popping)
MTT-1293