refactor!: remove SnapshotSystem
#1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFA11
commented
Mar 30, 2022
Comment on lines
-141
to
-153
| /// <summary> | ||
| /// Whether or not to enable Snapshot System for variable updates. Not supported in this version. | ||
| /// </summary> | ||
| public bool UseSnapshotDelta { get; internal set; } = false; | ||
| /// <summary> | ||
| /// Whether or not to enable Snapshot System for spawn and despawn commands. Not supported in this version. | ||
| /// </summary> | ||
| public bool UseSnapshotSpawn { get; internal set; } = false; | ||
| /// <summary> | ||
| /// When Snapshot System spawn is enabled: max size of Snapshot Messages. Meant to fit MTU. | ||
| /// </summary> | ||
| public int SnapshotMaxSpawnUsage { get; } = 1000; | ||
|
|
There was a problem hiding this comment.
! aka API-breaking part
mattwalsh-unity
approved these changes
Mar 30, 2022
| @@ -46,15 +46,14 @@ public class NetworkManager : MonoBehaviour, INetworkUpdateSystem | |||
| private static ProfilerMarker s_TransportDisconnect = new ProfilerMarker($"{nameof(NetworkManager)}.TransportDisconnect"); | |||
| #endif | |||
|
|
|||
| private const double k_TimeSyncFrequency = 1.0d; // sync every second, TODO will be removed once timesync is done via snapshots | |||
| private const double k_TimeSyncFrequency = 1.0d; // sync every second | |||
There was a problem hiding this comment.
Nice that you caught this
jeffreyrainy
approved these changes
Mar 30, 2022
|
Some of the tools tests had been rewritten (for snapshot) to allow extra messages (which happened to be SnapshotSystem messages). Here, you did not tighten those tests back. But I think this is still ok. Maybe the original tests were too strict, or making too much assumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since snapshotting feature is removed from 1.0 lineup, this PR is scraping it to reduce our overall API surface.
Changelog
SnapshotSystemTesting and Documentation