fix: PopulateScenePlacedObjects only checks IsSceneObject for null [MTT-3041] #1850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTT-3041 This fixes the issue when using a single scene containing both a NetworkManager and one or more in-scene placed NetworkObjects where a client could disconnect but not unload the scene and reconnect only to receive a soft synchronization error. The fix is to check for both HasValue and Value being true in order to account for already previously instantiated NetworkObjects.
MTT-3041 changelog update
…ceneobject-check-logic
com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs
Outdated
Show resolved
Hide resolved
Rosme
approved these changes
Mar 30, 2022
JesseOlmer
reviewed
Mar 30, 2022
com.unity.netcode.gameobjects/Runtime/SceneManagement/NetworkSceneManager.cs
Show resolved
Hide resolved
JesseOlmer
approved these changes
Mar 31, 2022
testproject/Assets/Tests/Runtime/NetworkSceneManager/NetworkSceneManagerPopulateInSceneTests.cs
Outdated
Show resolved
Hide resolved
…ceneobject-check-logic
…ck-logic' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/mtt-3041-populatesceneplacedobjects-sceneobject-check-logic
NoelStephensUnity
deleted the
fix/mtt-3041-populatesceneplacedobjects-sceneobject-check-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue when using a single scene containing both a NetworkManager and one or more in-scene placed NetworkObjects where a client could disconnect but not unload the scene and reconnect only to receive a soft synchronization error.
The fix is to check for both HasValue and Value being true in order to account for already previously instantiated NetworkObjects.
MTT-3041
Changelog
Testing and Documentation