fix: MTT-2991: Flush UnityTransport send queues on disconnect #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +32,7 @@ Additional documentation and release notes are available at [Multiplayer Documen | |||
| - Fixed issue where NetworkManager would continue starting even if the NetworkTransport selected failed. (#1780) | |||
| - Fixed issue when spawning new player if an already existing player exists it does not remove IsPlayer from the previous player (#1779) | |||
| - Fixed lack of notification that NetworkManager and NetworkObject cannot be added to the same GameObject with in-editor notifications (#1777) | |||
| - `UnityTransport` send queues are now flushed when calling `DisconnectLocalClient` or `DisconnectRemoteClient`. (#1847) | |||
There was a problem hiding this comment.
Most likely these are both nit-picks:
- Could you change how the fix is worded sort of like: "- Fixed issue where send queues were not being flushed when calling
DisconnectLocalClientorDisconnectRemoteClient. - Could you move it to the top to preserver a descending order? (my OCD kicking in)
mattwalsh-unity
approved these changes
Mar 29, 2022
dbuckley3d
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flush the
UnityTransportsend queues when callingDisconnectLocalClientorDisconnectRemoteClient. This brings the behavior more in line with what is happening on shutdown (it's weird to flush the queues on shutdown, but not on disconnect).See MTT-2991 for more details.
Changelog
UnityTransportsend queues are now flushed when callingDisconnectLocalClientorDisconnectRemoteClient.Testing and Documentation