Skip to content

fix: Ownership table entries not being removed on clients [MTT-2974] #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 28, 2022
Merged

fix: Ownership table entries not being removed on clients [MTT-2974] #1838

merged 7 commits into from
Mar 28, 2022

Conversation

NoelStephensUnity
Copy link
Collaborator

This addresses the issue where entries were not being removed from the NetworkSpawnManager.OwnershipToObjectsTable when UpdateOwnershipTable's isRemoving parameter was true and clients were not invoking the UpdateOwnershipTable method when they lost ownership.

MTT-2974

Changelog

  • Fixed issue where entries were not being removed from the NetworkSpawnManager.OwnershipToObjectsTable.

Testing and Documentation

  • Includes an update to an integration test.

@NoelStephensUnity
fix
9cb4947 
Spawn manager not removing entries from ownership table
@NoelStephensUnity
Update CHANGELOG.md
4f1924e 
MTT-2974
@NoelStephensUnity
fix
c25e4fd 
Removing the ownership check in InvokeBehaviourOnLostOwnership because clients still need to update their table when the owner has changed to remove their ownership entry in their local ownership table.
@NoelStephensUnity
test
cbe3e90 
updating the integration test to check and make sure that the OwnershipToObjectsTable is having entries removed when ownership is lost.
@NoelStephensUnity
update
3f10309 
removing some debug code
@NoelStephensUnity
update
08c5354 
adding PR number
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) March 28, 2022 15:08
TwoTenPvP
TwoTenPvP approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@TwoTenPvP TwoTenPvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏻

@NoelStephensUnity NoelStephensUnity merged commit d563072 into develop Mar 28, 2022
@NoelStephensUnity NoelStephensUnity deleted the fix/ownershiptoobjectstable-not-removing-entries-fix-pr1801 branch March 28, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoTenPvP TwoTenPvP TwoTenPvP approved these changes

@0xFA11 0xFA11 Awaiting requested review from 0xFA11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @TwoTenPvP