Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move UTP integration into NGO, delete UTP Adapter package #1823

Merged
merged 15 commits into from
Mar 23, 2022
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
Profiling/ @Unity-Technologies/multiplayer-tools
Metrics/ @Unity-Technologies/multiplayer-tools
/com.unity.netcode.gameobjects/Runtime/Transports/ @Unity-Technologies/multiplayer-server
/com.unity.netcode.adapter.utp/ @Unity-Technologies/multiplayer-server
/com.unity.netcode.gameobjects/Tests/Editor/Transports/ @Unity-Technologies/multiplayer-server
/com.unity.netcode.gameobjects/Tests/Runtime/Transports/ @Unity-Technologies/multiplayer-server
*.asmdef @mfatihmar
package.json @mfatihmar
AssemblyInfo.cs @mfatihmar
Expand Down
17 changes: 8 additions & 9 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,29 +1,28 @@
<!-- Replace this line with what this PR does and why. Describe what you'd like reviewers to know, how you applied the Engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. -->
<!-- Replace this block with what this PR does and why. Describe what you'd like reviewers to know, how you applied the engineering principles, and any interesting tradeoffs made. Delete bullet points below that don't apply, and update the changelog section as appropriate. -->

<!-- Add JIRA link here. Short version (e.g. MTT-123) also works and gets auto-linked. -->

<!-- Add RFC link here if applicable. -->

## Changelog

### com.unity.netcode.gameobjects
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed section separation since there is no other package under this repo anymore

- Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
- Fixed: If you update multiple packages, create a new section with a new header for the other package.
- Removed/Deprecated/Changed: Each bullet should be prefixed with Added, Fixed, Removed, Deprecated, or Changed to indicate where the entry should go.

## Testing and Documentation

* No tests have been added.
* Includes unit tests.
* Includes integration tests.
* No documentation changes or additions were necessary.
* Includes documentation for previously-undocumented public API entry points.
* Includes edits to existing public API documentation.
- No tests have been added.
- Includes unit tests.
- Includes integration tests.
- No documentation changes or additions were necessary.
- Includes documentation for previously-undocumented public API entry points.
- Includes edits to existing public API documentation.

<!-- Uncomment and mark items off with a * if this PR deprecates any API:
### Deprecated API
- [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry.
- [ ] An [api updater] was added.
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they should use instead.
-->
-->
2 changes: 0 additions & 2 deletions .yamato/project.metafile
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ projects:
packages:
- name: com.unity.netcode.gameobjects
path: com.unity.netcode.gameobjects
- name: com.unity.netcode.adapter.utp
path: com.unity.netcode.adapter.utp
Comment on lines -41 to -42
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less work on Yamato, faster CI, faster PRs!

test_editors:
- 2021.2
- 2020.3
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ This repository is broken into multiple components, each one implemented as a Un
```
.
├── com.unity.netcode.gameobjects # The core netcode SDK unity package (source + tests)
├── com.unity.netcode.adapter.utp # Transport wrapper for com.unity.transport
└── testproject # A Unity project with various test implementations & scenes which exercise the features in the above packages.
```

Expand Down
125 changes: 0 additions & 125 deletions com.unity.netcode.adapter.utp/CHANGELOG.md

This file was deleted.

7 changes: 0 additions & 7 deletions com.unity.netcode.adapter.utp/CHANGELOG.md.meta

This file was deleted.

9 changes: 0 additions & 9 deletions com.unity.netcode.adapter.utp/Documentation~/filter.yml

This file was deleted.

7 changes: 0 additions & 7 deletions com.unity.netcode.adapter.utp/Documentation~/index.md

This file was deleted.

9 changes: 0 additions & 9 deletions com.unity.netcode.adapter.utp/LICENSE.md

This file was deleted.

7 changes: 0 additions & 7 deletions com.unity.netcode.adapter.utp/LICENSE.md.meta

This file was deleted.

3 changes: 0 additions & 3 deletions com.unity.netcode.adapter.utp/README.md

This file was deleted.

7 changes: 0 additions & 7 deletions com.unity.netcode.adapter.utp/README.md.meta

This file was deleted.

8 changes: 0 additions & 8 deletions com.unity.netcode.adapter.utp/Runtime.meta

This file was deleted.

4 changes: 0 additions & 4 deletions com.unity.netcode.adapter.utp/Runtime/AssemblyInfo.cs

This file was deleted.

3 changes: 0 additions & 3 deletions com.unity.netcode.adapter.utp/Runtime/Metrics.meta

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

8 changes: 0 additions & 8 deletions com.unity.netcode.adapter.utp/Tests/Runtime.meta

This file was deleted.

8 changes: 0 additions & 8 deletions com.unity.netcode.adapter.utp/Tests/Runtime/Helpers.meta

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading