fix: key not found exception when client never connects #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // for the disconnect event. | ||
| if (!IsServer && !m_TransportIdToClientIdMap.ContainsKey(clientId)) | ||
| { | ||
| return clientId; |
There was a problem hiding this comment.
return 0; ? That would be just as valid as we don't really have a clientId here.
There was a problem hiding this comment.
Well, that is the issue at hand... zero is typically the server and to return the "commonly" known server id (0) would also be confusing. Since it is ulong, we can't return a negative value... so I was just returning the transport since the client never made it to connecting.
Yeah... it is sort of a coin toss for me... as either way we will return an "invalid client id" and both identifiers will be "incorrect"...with the transport Id being the "most correct...incorrect" return value. (if that makes sense...lesser of two evils kind of thing)
jeffreyrainy
approved these changes
Mar 21, 2022
NoelStephensUnity
deleted the
fix/nccbug-131-key-exception-when-client-never-connects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where when a client would try to connect to a server but never established a connection it would throw a key not found exception.
NCCBUG-130
Changelog
com.unity.netcode.gameobjects
Testing and Documentation