fix: player networkobject not added to client owned object list #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with a player not being added to the client's owned objects list. This also fixes the issue where dynamically spawned NetworkObjects were not getting added to the client's owned object list. This fix migrates the table into NetworkSpawnManager, removes the OwnedObjects list from NetworkClient (replaces it with a method), and provides automatic assignment and de-assignment of ownership to the NetworkSpawnManager's OwnershipToObjectsTable.
Log message and exception additions. White space removal. Extra-LF removal.
…client-owned-list
…client-owned-list
…client-owned-list
…ist' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/mtt-1585-player-networkobject-not-in-client-owned-list
0xFA11
reviewed
Mar 14, 2022
| { | ||
| return PlayerObject.NetworkManager.SpawnManager.GetClientOwnedObjects(ClientId); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
it might be better to return an empty list instead of null
…ist' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/mtt-1585-player-networkobject-not-in-client-owned-list
fixing some order of operations issues. reverting back to OwnedObjects get.
…client-owned-list
…client-owned-list
…client-owned-list
0xFA11
approved these changes
Mar 15, 2022
NoelStephensUnity
deleted the
fix/mtt-1585-player-networkobject-not-in-client-owned-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily addresses the issue where player NetworkObjects were not being added to the NetworkClients OwnedObjects list. However, it was also discovered that dynamically spawned NetworkObjects were not properly updating the NetworkClients OwnedObjects list as it was only updating this list if the ChangeOwnership or RemoveOwnership messages were sent (but not spawn messages).
This update fixes both issues by creating a NetworkSpawnManager.OwnershipToObjectsTable that is updated for all clients on the server-side and only for the owned objects of the client on the client-side.
MTT-1585
Changelog
com.unity.netcode.gameobjects
Testing and Documentation