Skip to content

feat: Remove Simulator Tools window #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 15, 2022

Conversation

simon-lemay-unity
Copy link
Contributor

MTT-2775

Remove the 'Simulator Tools' window that was accessible through the 'NetCode' menu item. It's now also possible to set these parameters through the 'Debug Simulator' section of the 'Unity Transport' component, and having two places to set the same settings was confusing. The component is the preferred way since it offers more advantages (different settings for different components, can be saved in the project, easier to discover, more consistent with other settings). The separate window could also be quite confusing since it used editor preferences for the settings (it's easy to forget they're set and they remain across projects) and because it only applied to the UTP adapter (since the menu is global, it was easy to think it could apply to other transports too).

Changelog

com.unity.netcode.adapter.utp

  • Removed: Removed the 'NetCode > Simulator Tools' menu to reduce confusion. The only way to set debug simulator parameters is now through the 'Debug Simulator' section of the 'Unity Transport' component.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@simon-lemay-unity simon-lemay-unity requested review from 0xFA11 and a team as code owners March 10, 2022 20:10
@simon-lemay-unity simon-lemay-unity enabled auto-merge (squash) March 14, 2022 21:37
@simon-lemay-unity simon-lemay-unity force-pushed the feat/remove-simulator-tools branch from 7283049 to b17be62 Compare March 15, 2022 17:45
@simon-lemay-unity simon-lemay-unity merged commit 58626b3 into develop Mar 15, 2022
@simon-lemay-unity simon-lemay-unity deleted the feat/remove-simulator-tools branch March 15, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants