fix: spawning new player does not remove previous #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwalsh-unity
suggested changes
Mar 7, 2022
| [UnityTest] | ||
| public IEnumerator SpawnAnotherPlayerObject() | ||
| { | ||
| var originalPlayer = m_PlayerNetworkObjects[1][1]; |
There was a problem hiding this comment.
I'm trying to rationalize to myself that I should know why I am looking this up by [1][1]. Worth a comment to explain.
| } | ||
|
|
||
| [UnityTest] | ||
| public IEnumerator SpawnAnotherPlayerObject() |
There was a problem hiding this comment.
I would title this "TestReplacementPlayerObjectCleanup" or similar. "SpawnAnotherPlayerObject", if I'm coming in cold, just tells me we are testing spawning yet another PlayerObject - a title that specifically conveys that you are checking that old player objects are de-player-ified will help future generations
mattwalsh-unity
approved these changes
Mar 7, 2022
NoelStephensUnity
deleted the
fix/mtt-1610-spawning-new-player-doesnt-remove-previous
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawning a new player object with SpawnAsPlayerObject does not set the IsPlayerObject property of the previous player object to false allowing for multiple player objects which shouldn't be the case.
MTT-1570
Changelog
com.unity.netcode.gameobjects
-Fixed: issue when spawning new player if an already existing player exists it does not remove IsPlayer from the previous player.
Testing and Documentation