feat: Implement GetCurrentRtt in the adapter #1755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johann-r-unity
approved these changes
Feb 28, 2022
| @@ -773,25 +773,23 @@ private void ExtractNetworkMetricsFromPipeline(NetworkPipeline pipeline, Network | |||
|
|
|||
| private int ExtractRtt(NetworkConnection networkConnection) | |||
| { | |||
| if (NetworkManager.IsServer) | |||
| if (m_Driver.GetConnectionState(networkConnection) != NetworkConnection.State.Connected) | |||
There was a problem hiding this comment.
Detail but why is the NetworkManager.IsServer check out of the method instead of adding it to the if(m_Driver.GetConnectionState(networkConnection) != NetworkConnection.State.Connected) ?
There was a problem hiding this comment.
Because we want ExtractRtt to work on servers too. Metrics want 0 for the RTT on servers, but GetCurrentRtt must work on servers too. So moving the check out of the method allows ExtractRtt to be used more widely.
thoward-unity
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MTT-2683
Implement
GetCurrentRttin the adapter, using the code already used for the metrics gathering. Had to make a few adjustments toExtractRttto make it easier to use inGetCurrentRtt.Note that the returned value only reflects RTT for reliable traffic, but this should be a good approximation of RTT for any kind of traffic (and with NGO sending most things reliably currently, the limitation is a bit moot).
Changelog
com.unity.netcode.adapter.utp
GetCurrentRttis now properly implemented.Testing and Documentation